[PATCH] Add support for missed and analysis optimization remarks.
Quentin Colombet
qcolombet at apple.com
Wed May 14 13:51:20 PDT 2014
Hi Diego,
This overall LGTM.
I have one concern though.
The LLVMContext begins to have a lot of its API dedicated to diagnostic report. All those helper functions calls LLVMContext::diagnose and I would prefer to have just this specific method (emitError being the exception) than having a profusion of such helpers in that class.
I think it would make sense to have those helper functions in the DiagnosticInfo header. That way it would be better self contained.
This is my 2 cents.
What do you think?
Thanks,
-Quentin
http://reviews.llvm.org/D3682
More information about the llvm-commits
mailing list