[PATCH] [X86 DAG] Lower vselects with a constant condition as blend+imm if possible

Nadav Rotem nrotem at apple.com
Wed May 14 13:25:13 PDT 2014


I forgot to mention that you will also need to update the cost model.  The low cost of vselects was deducted from the ISEL tables because the operation was marked as LEGAL. You will need to create new table entries in the cost model to list the selects that are marked as ‘custom’ as having low costs.

On May 14, 2014, at 1:22 PM, Nadav Rotem <nrotem at apple.com> wrote:

> Overall this change makes sense. I did not review the patch carefully but I noticed that Andrea did. When you commit please split this patch to the different optimizations: shuffle blends, BLENDI, etc.
> 
> http://reviews.llvm.org/D3752
> 
> 





More information about the llvm-commits mailing list