[patch][PR10367] Fix the design of GlobalAlias v2

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed May 14 12:08:10 PDT 2014


Starting a new thread to get a fresh view of the state of the patches.

The introduction of GlobalObject was already committed. These patches are
* rebased on top of trunk.
* include the feedback from the previous code review. Let me know if I
missed anything.
* Splits the manual removal of getAliasedGlobal to a separate patch.
* Includes some linker fixes I found while rereading the previous version.

One thing that I noticed with the discussion about the C api is that
LLVMAddAlias should probably not be changed, even if the constructor
of GlobalAlias is changed. I will try to split this into an
independent patch.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-2.patch
Type: application/octet-stream
Size: 15628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/018ef77b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-3.patch
Type: application/octet-stream
Size: 1102 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/018ef77b/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-2.patch
Type: application/octet-stream
Size: 37322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/018ef77b/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-3.patch
Type: application/octet-stream
Size: 11937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/018ef77b/attachment-0003.obj>


More information about the llvm-commits mailing list