[PATCH] [ASan tests] Add the first Windows-only lit test

Alexey Samsonov samsonov at google.com
Wed May 14 11:01:55 PDT 2014


w00t, glad to see this coming.

================
Comment at: test/asan/TestCases/Windows/thread_stack_array_left_oob.cc:1
@@ +1,2 @@
+// RUN: %clangxx_asan -O0 %s -Fe%t 2>&1
+// 'cat' is used below to work around FileCheck buffering bug which makes this
----------------
Why 2>&1 here?

================
Comment at: test/asan/TestCases/Windows/thread_stack_array_left_oob.cc:3
@@ +2,3 @@
+// 'cat' is used below to work around FileCheck buffering bug which makes this
+// test flaky.  FIXME: file an issue.
+// RUN: not %run %t 2>&1 | cat | FileCheck %s --check-prefix=CHECK
----------------
Timur Iskhodzhanov wrote:
> Please note: I'm intentionally not filing and issue before I commit this patch to make it much easier for someone working on FileCheck to reproduce.
> I'm afraid this issue exists only on Windows...
Okay... I would suggest to look at MemoryBuffer::getSTDIN() - FileCheck just uses LLVM libraries.

http://reviews.llvm.org/D3767






More information about the llvm-commits mailing list