[PATCH] R600: Use LDS and vectors for private memory

Tom Stellard tom at stellard.net
Wed May 14 10:58:20 PDT 2014


On Tue, May 13, 2014 at 07:19:32PM -0700, Matt Arsenault wrote:
> 
> On May 13, 2014, at 3:35 PM, Tom Stellard <tom at stellard.net> wrote:
> 
> >> 
> > 
> > The whole file is like this.  I can update all the functions in a follow
> > on patch.
> > 
> > The attached patch should address the rest of your comments.
> 
> 
> The new comment has a typo ‘consectuive’
> 
> AllocasToPromote looks unused
> 
> 

I've fixed these issues in the attached patch.

> I also noticed FeatureLocalMemorySize65536 on CI. I thought it was still 32K? In my manual it still says 32K in section 2.3.1

According to the register spec: COMPUTE_PGM_RSRC2.LDS_SIZE allows you to
allocate 16k dwords, so I think 65536 is correct.  Usually, the register
spec is more accurate.

-Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-R600-Use-LDS-and-vectors-for-private-memory.patch
Type: text/x-diff
Size: 49921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140514/c85080b8/attachment.patch>


More information about the llvm-commits mailing list