[PATCH] ARM-BE: test files for vector argument passing
James Molloy
james.molloy at arm.com
Wed May 14 09:59:03 PDT 2014
Hi Christian,
Thanks. It's good that the testing found at least one bug, so I don't feel unjustified in asking for it :)
It all looks good. I really hope you didn't have to go through all that by hand...
Cheers,
James
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:3968
@@ -3967,2 +3967,3 @@
SDValue Cvt;
- if (TLI.isBigEndian() && SrcVT.isVector())
+ if (TLI.isBigEndian() && SrcVT.isVector() &&
+ SrcVT.getVectorNumElements() > 1)
----------------
Ah ha! I suspected such testing was necessary to weed out more bugs :)
http://reviews.llvm.org/D3766
More information about the llvm-commits
mailing list