[compiler-rt] r208624 - Add %run to new lit test

[Greg Fitzgerald]

I have a local bot that runs a Go script that traverses the test tree and adds %run if it is missing.  Should I add the script and add it to the build?  Or need to port to Python?

 

Thanks,

Greg

 

 

From: Kostya Serebryany [mailto:kcc at google.com] 
Sent: Monday, May 12, 2014 9:15 PM
To: Greg Fitzgerald
Cc: Commit Messages and Patches for LLVM
Subject: Re: [compiler-rt] r208624 - Add %run to new lit test

 

Is it possible to make tests fail on regular Linux if they don't have %run? 

Otherwise you will be fixing tests like this for eternity.

 

--kcc 

 

On Tue, May 13, 2014 at 12:17 AM, Greg Fitzgerald <gregf at codeaurora.org> wrote:

Author: garious
Date: Mon May 12 15:17:14 2014
New Revision: 208624

URL: http://llvm.org/viewvc/llvm-project?rev=208624 <http://llvm.org/viewvc/llvm-project?rev=208624&view=rev> &view=rev
Log:
Add %run to new lit test

Modified:
    compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc

Modified: compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624 <http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc?rev=208624&r1=208623&r2=208624&view=diff> &r1=208623&r2=208624&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/Linux/coverage-module-unloaded.cc Mon May 12 15:17:14 2014
@@ -4,8 +4,8 @@
 // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSHARED %s -shared -o %T/libcoverage_module_unloaded_test_2.so -fPIC
 // RUN: %clangxx_asan -mllvm -asan-coverage=1 -DSO_DIR=\"%T\" %s -o %t
 // RUN: export ASAN_OPTIONS=coverage=1:verbosity=1
-// RUN: %t 2>&1         | FileCheck %s
-// RUN: %t foo 2>&1         | FileCheck %s
+// RUN: %run %t 2>&1         | FileCheck %s
+// RUN: %run %t foo 2>&1         | FileCheck %s
 //
 // https://code.google.com/p/address-sanitizer/issues/detail?id=263
 // XFAIL: android


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140513/618fc876/attachment.html>