[lld] r208670 - [ELF] Emit DT_TEXTREL dynamic table flag.

[Simon Atanasyan]

Hi,

Probably I understood your idea improperly. Do you suggest to
introduce a new Pass where scan all dynamic relocations to see if any
modifies a read-only section? If so, what benefits do we get from this
separate Pass?

On Tue, May 13, 2014 at 5:15 PM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
> I thought you were planning to make this a Pass instead ?

[...]

> On 5/13/2014 2:37 AM, Simon Atanasyan wrote:
>>
>> Author: atanasyan
>> Date: Tue May 13 02:37:09 2014
>> New Revision: 208670
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=208670&view=rev
>> Log:
>> [ELF] Emit DT_TEXTREL dynamic table flag.
>>
>> If one or more dynamic relocation might modify a read-only section,
>> dynamic table should contain DT_TEXTREL tag.
>>
>> The patch introduces new `RelocationTable::canModifyReadonlySection()`
>> method. This method checks through the relocations to see if any modifies
>> a read-only section. The DynamicTable class calls this method and emits
>> the DT_TEXTREL tag if necessary.

-- 
Simon Atanasyan