[PATCH] ARMEB: Fix byte order of EH frame unwinding instructions

James Molloy james.molloy at arm.com
Tue May 13 03:56:33 PDT 2014


Hi Christian,

I have some style nitpicks, but I'm happy for you to commit once those are fixed.

Cheers,

James

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1216
@@ -1212,3 +1215,3 @@
   // Emit unwind opcodes
-  EmitBytes(StringRef(reinterpret_cast<const char *>(Opcodes.data()),
-                      Opcodes.size()));
+  assert((Opcodes.size()%4) == 0 &&
+         "Unwind opcode size for __aeabi_cpp_unwind_pr0 must be multiple of 4");
----------------
Style nitpicks: Spaces between operators and operands (x%4 -> x % 4, i+=4 -> i += 4), upper case I for loop induction variable.

http://reviews.llvm.org/D3704






More information about the llvm-commits mailing list