[PATCH] [ARM64-BE] Fix byte order of CIE and FDE frames for exception handling
James Molloy
james.molloy at arm.com
Tue May 13 03:47:39 PDT 2014
Hi Christian,
This looks reasonable - I only have one comment. Can I assume there'll be an AArch32 patch coming to fix the same thing too?
Cheers,
James
================
Comment at: lib/Target/ARM64/MCTargetDesc/ARM64AsmBackend.cpp:540
@@ +539,3 @@
+ const unsigned Offset = Fixup.getOffset();
+ for (unsigned i = 0; i != 4; ++i)
+ Data[Offset + 3 - i] |= uint8_t((Value >> (i * 8)) & 0xff);
----------------
This can be greatly simplified by using ByteSwap_32 from Support/MathExtras.h.
http://reviews.llvm.org/D3741
More information about the llvm-commits
mailing list