[llvm] r208607 - TableGen: use PrintMethods to print more aliases

[Tim Northover]

On 13 May 2014, at 08:04, Simon Atanasyan <simon at atanasyan.com> wrote:
>> +  void addOperand(StringRef Op, int OpIdx, int PrintMethodIdx = -1) {
>> +    assert(OpIdx >= 0 && OpIdx < 0xFE && "Idx out of range");
>> +    assert(PrintMethodIdx == -1 || PrintMethodIdx < 0xFF && "Idx out of range");
> 
> Just a bit curious, is say -100 a valid value for the PrintMethodIdx?
> Maybe this assert should be written as "assert(PrintMethodIdx >= -1 &&
> PrintMethodIdx < 0xFF && "Idx out of range")"?

Oh, good point! I've fixed this in r208679.

Thanks.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140513/ec7a7968/attachment.sig>