[PATCH] [sanitizer] Support sandboxing in sanitizer coverage.

Kostya Serebryany kcc at google.com
Tue May 13 01:31:25 PDT 2014


================
Comment at: include/sanitizer/common_interface_defs.h:27
@@ -26,1 +26,3 @@
 #endif
+  struct __sanitizer_sandbox_arguments {
+    int coverage_sandboxed;
----------------
Alexander Potapenko wrote:
> I think we need some "version" parameter to distinguish between different versions of this structure.
use typedef so that you don't need to repeat struct every time

================
Comment at: include/sanitizer/common_interface_defs.h:29
@@ +28,3 @@
+    int coverage_sandboxed;
+    int coverage_fd;
+    size_t coverage_max_block_size;
----------------
I wonder how this is going to work on Windows

================
Comment at: include/sanitizer/common_interface_defs.h:30
@@ +29,3 @@
+    int coverage_fd;
+    size_t coverage_max_block_size;
+  };
----------------
Alexander Potapenko wrote:
> Should this really be passed through the sandbox arguments?
comments?

================
Comment at: lib/sanitizer_common/sanitizer_coverage.cc:78
@@ -73,1 +77,3 @@
 
+struct CovHeader {
+  int pid;
----------------
comments?

http://reviews.llvm.org/D3726






More information about the llvm-commits mailing list