[PATCH] Add observers to Input Graph

Simon Atanasyan simon at atanasyan.com
Mon May 12 23:25:52 PDT 2014


LGTM

================
Comment at: include/lld/Core/InputGraph.h:74
@@ +73,3 @@
+  /// being returned.
+  void registerObserver(std::function<void(File *)> &fn);
+
----------------
Maybe it is better to use the `llvm::function_ref` class to be consistent with main LLVM code.

http://llvm.org/docs/ProgrammersManual.html#passing-functions-and-other-callable-objects

http://reviews.llvm.org/D3735






More information about the llvm-commits mailing list