[llvm] r208628 - Suggested improvement by Rafael Espindola to use isa<> in a few places

Kevin Enderby enderby at apple.com
Mon May 12 13:45:00 PDT 2014


Author: enderby
Date: Mon May 12 15:45:00 2014
New Revision: 208628

URL: http://llvm.org/viewvc/llvm-project?rev=208628&view=rev
Log:
Suggested improvement by Rafael Espindola to use isa<> in a few places
instead of dyn_cast<>.

Modified:
    llvm/trunk/tools/llvm-nm/llvm-nm.cpp

Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=208628&r1=208627&r2=208628&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Mon May 12 15:45:00 2014
@@ -182,19 +182,19 @@ static bool compareSymbolName(const NMSy
 }
 
 static char isSymbolList64Bit(SymbolicFile *Obj) {
-  if (dyn_cast<IRObjectFile>(Obj))
+  if (isa<IRObjectFile>(Obj))
     return false;
-  else if (dyn_cast<COFFObjectFile>(Obj))
+  else if (isa<COFFObjectFile>(Obj))
     return false;
   else if (MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(Obj))
     return MachO->is64Bit();
-  else if (dyn_cast<ELF32LEObjectFile>(Obj))
+  else if (isa<ELF32LEObjectFile>(Obj))
     return false;
-  else if (dyn_cast<ELF64LEObjectFile>(Obj))
+  else if (isa<ELF64LEObjectFile>(Obj))
     return true;
-  else if (dyn_cast<ELF32BEObjectFile>(Obj))
+  else if (isa<ELF32BEObjectFile>(Obj))
     return false;
-  else if(dyn_cast<ELF64BEObjectFile>(Obj))
+  else if(isa<ELF64BEObjectFile>(Obj))
     return true;
   else
     return false;





More information about the llvm-commits mailing list