[PATCH] [ELF] Emit DT_TEXTREL dynamic table flag
Rui Ueyama
ruiu at google.com
Mon May 12 13:01:41 PDT 2014
LGTM
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:959
@@ +958,3 @@
+ bool canModifyReadonlySection() const {
+ for (const auto &rel : _relocs)
+ if ((rel.first->permissions() & DefinedAtom::permRW_) !=
----------------
can you expand "auto"?
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:960
@@ +959,3 @@
+ for (const auto &rel : _relocs)
+ if ((rel.first->permissions() & DefinedAtom::permRW_) !=
+ DefinedAtom::permRW_)
----------------
nit: fit in one line
http://reviews.llvm.org/D3716
More information about the llvm-commits
mailing list