[compiler-rt] r208591 - __clear_cache: decorate with COMPILER_RT_EXPORT

[Jonathan Roelofs]

kcc, does r208593 fix it?

Jon

On 5/12/14, 12:14 PM, Kostya Serebryany wrote:
> our bot is sad:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/3364/steps/build%20stage1%20clang/logs/stdio
>
> FAILED: /usr/bin/cc  -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sections -Wall -O3 -DNDEBUG -Iprojects/compiler-rt/lib/builtins -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins -Iinclude -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/include    -UNDEBUG  -m32 -std=c99 -MMD -MT projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o -MF "projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o.d" -o projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.i386.dir/clear_cache.c.o   -c /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c
> /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c:35:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’
>   COMPILER_RT_EXPORT void
>                      ^
> FAILED: /usr/bin/cc  -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-comment -ffunction-sections -fdata-sections -Wall -O3 -DNDEBUG -Iprojects/compiler-rt/lib/builtins -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins -Iinclude -I/home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/include    -UNDEBUG  -m64 -std=c99 -MMD -MT projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o -MF "projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o.d" -o projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.x86_64.dir/clear_cache.c.o   -c /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c
> /home/dtoolsbot/build/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/builtins/clear_cache.c:35:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘void’
>   COMPILER_RT_EXPORT void
>                      ^
> ninja: build stopped: subcommand failed.
>
>
>
> On Mon, May 12, 2014 at 8:28 PM, Saleem Abdulrasool <compnerd at compnerd.org <mailto:compnerd at compnerd.org>> wrote:
>
>     Author: compnerd
>     Date: Mon May 12 11:28:11 2014
>     New Revision: 208591
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=208591&view=rev
>     Log:
>     __clear_cache: decorate with COMPILER_RT_EXPORT
>
>     Use COMPILER_RT_EXPORT rather than COMPILER_RT_ABI for this function.  Adding an
>     explicit PCS standard to the function causes a mismatch between the
>     declarations.  Furthermore, the function is implemented in C, and should take
>     the CC based on the target triple.
>
>     Modified:
>          compiler-rt/trunk/lib/builtins/clear_cache.c
>
>     Modified: compiler-rt/trunk/lib/builtins/clear_cache.c
>     URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/clear_cache.c?rev=208591&r1=208590&r2=208591&view=diff
>     ==============================================================================
>     --- compiler-rt/trunk/lib/builtins/clear_cache.c (original)
>     +++ compiler-rt/trunk/lib/builtins/clear_cache.c Mon May 12 11:28:11 2014
>     @@ -32,7 +32,7 @@
>        * specified range.
>        */
>
>     -COMPILER_RT_ABI void
>     +COMPILER_RT_EXPORT void
>       __clear_cache(void* start, void* end)
>       {
>       #if __i386__ || __x86_64__
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded