[PATCH] [ASan tests] Add Windows-specific flags to lib/asan/tests/CMakeLists.txt

[Hans Wennborg]

On Mon, May 12, 2014 at 11:04 AM, Hans Wennborg <hans at chromium.org> wrote:
> On Mon, May 12, 2014 at 10:58 AM, Timur Iskhodzhanov
> <timurrrr at google.com> wrote:
>> Hans,
>>
>> Can you please work on the driver support today?
>
> Sure, will do. Just waiting for my current build to finish.

Should be fixed in r208613.

>> 2014-05-12 21:57 GMT+04:00 Reid Kleckner <rnk at google.com>:
>>
>>> On Mon, May 12, 2014 at 10:50 AM, Alexey Samsonov <samsonov at google.com>
>>> wrote:
>>>>
>>>> -Xclang is horrible. Please add a FIXME assigned to you to remove this as
>>>> soon as the necessary flags are supported by clang-cl.
>>>
>>>
>>> I'd just do it first.  We basically add things as needed, as long as they
>>> don't conflict.
>>>
>>>>
>>>> ================
>>>> Comment at: lib/asan/tests/CMakeLists.txt:77
>>>> @@ -50,2 +76,3 @@
>>>>  # Unit tests require libstdc++.
>>>> -set(ASAN_UNITTEST_COMMON_LINKFLAGS -lstdc++)
>>>> +if(NOT MSVC)
>>>> +  set(ASAN_UNITTEST_COMMON_LINKFLAGS -lstdc++)
>>>> ----------------
>>>> Why do you need this? If there is no libstdc++ on Windows, you should
>>>> instead detect this in the build system and introduce
>>>> COMPILER_RT_HAS_LIBSTDCXX like we do for libpthread and libdl.
>>>>
>>>> ================
>>>> Comment at: lib/asan/tests/CMakeLists.txt:106
>>>> @@ -76,3 +105,3 @@
>>>>
>>>> -set(ASAN_UNITTEST_NOINST_LINKFLAGS
>>>> -  ${ASAN_UNITTEST_COMMON_LINKFLAGS} -lm)
>>>> +if(NOT MSVC)
>>>> +  set(ASAN_UNITTEST_NOINST_LINKFLAGS
>>>> ----------------
>>>> ditto
>>>>
>>>> http://reviews.llvm.org/D3720
>>>>
>>>>
>>>
>>