[PATCH] [ASan tests] Add Windows-specific flags to lib/asan/tests/CMakeLists.txt

Alexey Samsonov samsonov at google.com
Mon May 12 10:50:43 PDT 2014


-Xclang is horrible. Please add a FIXME assigned to you to remove this as soon as the necessary flags are supported by clang-cl.

================
Comment at: lib/asan/tests/CMakeLists.txt:77
@@ -50,2 +76,3 @@
 # Unit tests require libstdc++.
-set(ASAN_UNITTEST_COMMON_LINKFLAGS -lstdc++)
+if(NOT MSVC)
+  set(ASAN_UNITTEST_COMMON_LINKFLAGS -lstdc++)
----------------
Why do you need this? If there is no libstdc++ on Windows, you should instead detect this in the build system and introduce
COMPILER_RT_HAS_LIBSTDCXX like we do for libpthread and libdl.

================
Comment at: lib/asan/tests/CMakeLists.txt:106
@@ -76,3 +105,3 @@
 
-set(ASAN_UNITTEST_NOINST_LINKFLAGS
-  ${ASAN_UNITTEST_COMMON_LINKFLAGS} -lm)
+if(NOT MSVC)
+  set(ASAN_UNITTEST_NOINST_LINKFLAGS
----------------
ditto

http://reviews.llvm.org/D3720






More information about the llvm-commits mailing list