[PATCH] [ASan tests] Make simple pthread tests compile and pass on Windows

Timur Iskhodzhanov timurrrr at google.com
Mon May 12 10:45:01 PDT 2014


================
Comment at: lib/asan/tests/asan_test_utils.h:47
@@ +46,3 @@
+#else
+typedef HANDLE pthread_t;
+
----------------
Kostya Serebryany wrote:
> I'd prefer this code to be in a separate .h file included here. 
Done -- and moved to sanitizer_common/tests as in fact we use pthread stuff in sanitizer tests too.

================
Comment at: lib/asan/tests/asan_test_utils.h:61
@@ +60,3 @@
+
+inline void my_pthread_create(pthread_t *thread, void *attr,
+                              void *(*start_routine)(void *), void *arg) {
----------------
Kostya Serebryany wrote:
> maybe win32_pthread_foo ? 
On the second thought, I think we don't need macros at all there?

http://reviews.llvm.org/D3725






More information about the llvm-commits mailing list