[PATCH] Implement ADRP CSE for global symbols

Quentin Colombet qcolombet at apple.com
Mon May 12 09:45:42 PDT 2014


Hi Jiangning,

> also I think applying this alignment hook to "internal globals" should be orthogonal with -global-merge-on-external

Makes sense.

>  I introduced another command line switch -global-merge-aligned.

That’s a good idea, thanks!

That said, shouldn’t we set the natural alignment for external globals by default? I.e., I guess externals uses will assume that at least the natural alignment is set.

Anyway, I’ll give a shot to the new patch.

Thanks,
-Quentin

http://reviews.llvm.org/D3432






More information about the llvm-commits mailing list