[PATCH] [ASan tests] Make simple pthread tests compile and pass on Windows

Kostya Serebryany kcc at google.com
Mon May 12 09:27:32 PDT 2014


================
Comment at: lib/asan/tests/asan_test_utils.h:47
@@ +46,3 @@
+#else
+typedef HANDLE pthread_t;
+
----------------
I'd prefer this code to be in a separate .h file included here. 

================
Comment at: lib/asan/tests/asan_test_utils.h:61
@@ +60,3 @@
+
+inline void my_pthread_create(pthread_t *thread, void *attr,
+                              void *(*start_routine)(void *), void *arg) {
----------------
maybe win32_pthread_foo ?

http://reviews.llvm.org/D3725






More information about the llvm-commits mailing list