[PATCH] ARM: Implement big endian bit-conversion for NEON types

James Molloy james.molloy at arm.com
Mon May 12 05:05:46 PDT 2014


Hi Christian,

Thanks, but I'm afraid that's not sufficient. That testcase has all arguments passed as pointers, which it then loads. It does not test vector argument passing. See for example test/CodeGen/ARM64/big-endian-callee.ll and test/CodeGen/ARM64/big-endian-caller.ll.

Please could you add an equivalent testcase for ARM.

Cheers,

James

> -----Original Message-----
> From: Christian Pirker [mailto:cpirker at a-bix.com]
> Sent: 12 May 2014 12:44
> To: cpirker at a-bix.com; James Molloy
> Cc: kanheim at a-bix.com; Amara Emerson; llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] ARM: Implement big endian bit-conversion for NEON
> types
> 
> Hi James,
> 
> I added the hard-float testcase to the test file "test/CodeGen/ARM/big-
> endian-neon-bitconv.ll".
> I committed this patch as rL208538.
> 
> Thanks,
> Christian
> 
> http://reviews.llvm.org/D3651
> 
>

http://reviews.llvm.org/D3651






More information about the llvm-commits mailing list