[PATCH] R600/SI: Fix unreachable on branch on constant.

Matt Arsenault arsenm2 at gmail.com
Fri May 9 16:00:36 PDT 2014


On May 9, 2014, at 9:48 AM, Tom Stellard <tom at stellard.net> wrote:

> On Wed, May 07, 2014 at 07:29:59PM +0000, Matt Arsenault wrote:
>> Ping
>> 
> 
> This breaks a few of the lit tests for me.  Does SimplifyCFG preserve
> structured control flow?  Also, if SIAnnotateControlFlow requires this
> pass to function correctly then we should add it as a dependency of
> SIAnnotateControlFlow instead of manually adding it to the list of passes.
> 

I don’t think it did last time I tried. I don’t think SimplifyCFG does anything that introduces new unstructured CF, but I’m not sure. Alternatively, I originally just made it handle the branch on constant case, but there was some problem with that I don’t remember



More information about the llvm-commits mailing list