[PATCH] Fix hardcoded path seperator in two code locations

Reid Kleckner rnk at google.com
Fri May 9 09:58:49 PDT 2014


LGTM

Let's be consistent with what append does.  If users want to do cross-compiling, we'll need to thread a flag down to fs::append() so it also does the right thing.

================
Comment at: include/llvm/Support/Path.h:301
@@ +300,3 @@
+/// @result const char* to the preferred separator, null-terminated.
+const char *get_separator();
+
----------------
This should return a StringRef.

http://reviews.llvm.org/D3687






More information about the llvm-commits mailing list