[PATCH] [ARM64] Add diagnostics for bitfield extract/insert instructions

Bradley Smith bradley.smith at arm.com
Fri May 9 07:25:33 PDT 2014


Hi t.p.northover,

Patch to add diagnostics for bitfield extract/insert instructions.

Unfortunately, since ARM64 models all these instructions as aliases, the checks need to be done at the time the alias is seen rather then during instruction validation as AArch4 does it, hence we need to extend some of the hacks a little. It is up for debate whether the bitfield instructions should be implemented in this manner, or whether they should be modeled as separate instructions. (Although perhaps for a different patch).

As with my previous patches, there is no testcase for this as it is part of the merge of MC/AArch64/basic-a64-diagnostics.s.

http://reviews.llvm.org/D3702

Files:
  lib/Target/ARM64/AsmParser/ARM64AsmParser.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3702.9261.patch
Type: text/x-patch
Size: 4012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140509/9c3a1c48/attachment.bin>


More information about the llvm-commits mailing list