[PATCH] [ASan tests] Use clang-cl to build tests on Windows

Alexey Samsonov samsonov at google.com
Thu May 8 13:22:22 PDT 2014


LGTM modulo nits.

================
Comment at: CMakeLists.txt:65
@@ +64,3 @@
+    set(COMPILER_RT_TEST_COMPILER_EXE "-o")
+    set(COMPILER_RT_TEST_COMPILER_OUT "-o")
+  else()
----------------
_OUT makes no sense to me. You can probably use EXE/OBJ instead.

================
Comment at: cmake/Modules/AddCompilerRT.cmake:140
@@ -140,1 +139,3 @@
+    COMMAND ${COMPILER_RT_TEST_COMPILER} ${TEST_OBJECTS}
+            ${COMPILER_RT_TEST_COMPILER_EXE}"${output_bin}"
             ${TEST_LINK_FLAGS}
----------------
Sanity check: is it ok to not have a space between ${COMPILER_RT_TEST_COMPILER_EXE} and "${output_bin}" ?

http://reviews.llvm.org/D3680






More information about the llvm-commits mailing list