[llvm] r208309 - Add isOSFreeBSD triple test

[Saleem Abdulrasool]

On Thu, May 8, 2014 at 7:25 AM, Ed Maste <emaste at freebsd.org> wrote:

> On 8 May 2014 10:01, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> > On Thu, May 08, 2014 at 09:54:32AM -0400, Ed Maste wrote:
> >> On 8 May 2014 09:25, Joerg Sonnenberger <joerg at britannica.bec.de>
> wrote:
> >> > I find this not really helpful and just obscuring the source.
> >>
> >> I don't disagree, but I preferred to be consistent what's already
> >> there.  I'm happy enough to revert this and make the clang change
> >> below, if that's preferable.
> >
> > Yes, please. For whatever reason that Apple decided to have multiple OS
> > names, it doesn't apply to FreeBSD.
>
> Nor Linux, although isOSLinux() was added in r189604 and equivalent
> checks were changed to use it.
>

My $0.02 USD (not sure if its worth anything though) is that we keep this.
 Having had to deal with renaming the triples for Windows, having these
methods makes for a much easier and cleaner interaction between LLVM and
clang (and lldb as well).  It also allows for LLVM to change internals
without breaking external consumers.


> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140508/d13d0faf/attachment.html>