[PATCH] Implement ADRP CSE for global symbols

Quentin Colombet qcolombet at apple.com
Thu May 8 10:01:28 PDT 2014


Hi Jiangning,

Thanks for the update.

I’ll give a shot at the patch as it is and get back to you with performance numbers.

Cheers,

-Quentin

================
Comment at: lib/Transforms/Scalar/GlobalMerge.cpp:215
@@ +214,3 @@
+
+    if (EnableGlobalMergeOnExternal && IsExternal) {
+      // If the alignment is not a power of 2, round up to the next power of 2.
----------------
Any reason why we do not want to set an alignment for the internal too?

http://reviews.llvm.org/D3432






More information about the llvm-commits mailing list