[llvm] r208009 - Remove a call to std::exit in a library. Make "Help" return

Eric Christopher echristo at gmail.com
Tue May 6 09:37:28 PDT 2014


Should be fixed thusly:

dzur:~/sources/llvm/tools> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M lib/MC/SubtargetFeature.cpp
M tools/llc/llc.cpp
Committed r208102

Sorry about that.

-eric

On Tue, May 6, 2014 at 8:48 AM, Eric Christopher <echristo at gmail.com> wrote:
> Interesting, I wasn't seeing it but I'll give it a look.
>
> Thanks!
>
> -eric
>
> On May 6, 2014 8:44 AM, "scott douglass" <sdouglass at arm.com> wrote:
>>
>> Hi,
>>
>> This patch is making 'llc -mcpu=help' land on an assert for me (after a
>> repetition of the help output and some spurious not-recognized messages).
>> Is it just me?
>>
>> > llc -mcpu=help
>> Available CPUs for this target:
>> ...
>> Available features for this target:
>> ...
>> Use +feature to enable a feature, or -feature to disable it.
>> For example, llc -mcpu=mycpu -mattr=+feature1,-feature2
>> 'help' is not a recognized processor for this target (ignoring processor)
>> Available CPUs for this target:
>> ...
>> 'help' is not a recognized processor for this target (ignoring processor)
>> 'help' is not a recognized processor for this target (ignoring processor)
>> 'help' is not a recognized processor for this target (ignoring processor)
>> llc:
>>
>> /tmp/plgbuild/abs_build/OpenSource_llvm_0_0_562_2331917/trunk/work/src/llvm/
>> lib/Target/X86/X86Subtarget.cpp:234: void
>> llvm::X86Subtarget::resetSubtargetFeatures(llvm::StringRef,
>> llvm::StringRef): Assertion `(!In64BitMode || HasX86_64) && "64-bit code
>> requested on a subtarget that doesn't support it!"' failed.
>> ...
>>
>> > -----Original Message-----
>> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> > bounces at cs.uiuc.edu] On Behalf Of Eric Christopher
>> > Sent: 05 May 2014 23:02
>> > To: llvm-commits at cs.uiuc.edu
>> > Subject: [llvm] r208009 - Remove a call to std::exit in a library. Make
>> "Help"
>> > return
>> >
>> > Author: echristo
>> > Date: Mon May  5 17:01:47 2014
>> > New Revision: 208009
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=208009&view=rev
>> > Log:
>> > Remove a call to std::exit in a library. Make "Help" return a 0 as a
>> default
>> > answer.
>> >
>> > Modified:
>> >     llvm/trunk/lib/MC/SubtargetFeature.cpp
>> > [...]
>>
>>
>>
>



More information about the llvm-commits mailing list