[compiler-rt] r208070 - [ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1

[Timur Iskhodzhanov]

Author: timurrrr
Date: Tue May  6 03:21:50 2014
New Revision: 208070

URL: http://llvm.org/viewvc/llvm-project?rev=208070&view=rev
Log:
[ASan/Win] Don't crash when ASAN_OPTIONS have disable_core=1

Reviewed at http://reviews.llvm.org/D3610

Modified:
    compiler-rt/trunk/lib/asan/asan_rtl.cc
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc

Modified: compiler-rt/trunk/lib/asan/asan_rtl.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=208070&r1=208069&r2=208070&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_rtl.cc (original)
+++ compiler-rt/trunk/lib/asan/asan_rtl.cc Tue May  6 03:21:50 2014
@@ -178,7 +178,8 @@ static void ParseFlagsFromString(Flags *
 
   ParseFlag(str, &f->disable_core, "disable_core",
       "Disable core dumping. By default, disable_core=1 on 64-bit to avoid "
-      "dumping a 16T+ core file.");
+      "dumping a 16T+ core file. "
+      "Ignored on OSes that don't dump core by default.");
 
   ParseFlag(str, &f->allow_reexec, "allow_reexec",
       "Allow the tool to re-exec the program. This may interfere badly with "

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=208070&r1=208069&r2=208070&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Tue May  6 03:21:50 2014
@@ -185,7 +185,7 @@ void DumpProcessMap() {
 }
 
 void DisableCoreDumper() {
-  UNIMPLEMENTED();
+  // Do nothing.
 }
 
 void ReExec() {