[llvm] r208012 - Remove a now unnecessary function since all calls have one version
Eric Christopher
echristo at gmail.com
Mon May 5 15:36:07 PDT 2014
Author: echristo
Date: Mon May 5 17:36:07 2014
New Revision: 208012
URL: http://llvm.org/viewvc/llvm-project?rev=208012&view=rev
Log:
Remove a now unnecessary function since all calls have one version
and inline it into its caller.
Modified:
llvm/trunk/lib/MC/SubtargetFeature.cpp
Modified: llvm/trunk/lib/MC/SubtargetFeature.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/SubtargetFeature.cpp?rev=208012&r1=208011&r2=208012&view=diff
==============================================================================
--- llvm/trunk/lib/MC/SubtargetFeature.cpp (original)
+++ llvm/trunk/lib/MC/SubtargetFeature.cpp Mon May 5 17:36:07 2014
@@ -51,18 +51,6 @@ static inline bool isEnabled(const Strin
return Ch == '+';
}
-/// PrependFlag - Return a string with a prepended flag; '+' or '-'.
-///
-static inline std::string PrependFlag(const StringRef Feature,
- bool IsEnabled) {
- assert(!Feature.empty() && "Empty string");
- if (hasFlag(Feature))
- return Feature;
- std::string Prefix = IsEnabled ? "+" : "-";
- Prefix += Feature;
- return Prefix;
-}
-
/// Split - Splits a string of comma separated items in to a vector of strings.
///
static void Split(std::vector<std::string> &V, const StringRef S) {
@@ -110,11 +98,10 @@ static std::string Join(const std::vecto
/// Adding features.
void SubtargetFeatures::AddFeature(const StringRef String) {
- // Don't add empty features
- if (!String.empty()) {
- // Convert to lowercase, prepend flag and add to vector
- Features.push_back(PrependFlag(String.lower(), true));
- }
+ // Don't add empty features or features we already have.
+ if (!String.empty())
+ // Convert to lowercase, prepend flag if we don't already have a flag.
+ Features.push_back(hasFlag(String) ? String.str() : "+" + String.lower());
}
/// Find KV in array using binary search.
More information about the llvm-commits
mailing list