[PATCH] [tablegen] !strconcat accepts more than two arguments but this wasn't documented or tested.
Daniel Sanders
daniel.sanders at imgtec.com
Fri May 2 11:31:04 PDT 2014
Hi Tim,
Thanks for the review.
================
Comment at: docs/TableGen/LangIntro.rst:163
@@ -162,3 +162,3 @@
``!strconcat(a, b)``
A string value that is the result of concatenating the 'a' and 'b' strings.
----------------
Tim Northover wrote:
> This should probably be updated to either !strconcat(a, ...) or !strconcat(a, b, ...). Is a single argument supported, BTW?
I agree, I'll update it to !strconcat(a, b, ...)
> Is a single argument supported, BTW?
No, it reports an error if it only gets one argument.
http://reviews.llvm.org/D3485
More information about the llvm-commits
mailing list