[PATCH] [InstCombine] Combine adjacent i8 loads.

Andrew Trick atrick at apple.com
Fri May 2 10:17:40 PDT 2014


On May 2, 2014, at 9:32 AM, Arnold Schwaighofer <aschwaighofer at apple.com> wrote:

> I don't think the above transformation (building a value of a bigger type from a smaller type) is going to interfere with regular SLP vectorization because we start bottom-up (sink to source) and we don't have patterns that would start at an "or reduction" (bigger than 2 operations). If we implement a second transformation that starts from loads and widens operations top-down, then, I agree with Andy, we would have to be careful about phase ordering.

My concern was that a chain that appeared profitable before no longer appears profitable because we don’t see the scalar loads and think we need vector insertion without realizing it can be folded away. If you don’t think that’s an issue, or can be easily fixed then I believe you.

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140502/08f0b105/attachment.html>


More information about the llvm-commits mailing list