[PATCH] [InstCombine] Combine adjacent i8 loads.

Chandler Carruth chandlerc at gmail.com
Thu May 1 15:52:50 PDT 2014


I think I would prefer to implement this as a standalone pass until we have
some clear phase ordering need for it in a utility like instcombine.

My suggestion: a pass that runs right after GVN.

I would also use the domtree rather than the basic block structure.

I think it really needs to handle arbitrary sizes, and both loads and
stores. You don't want to scan multiple times for this.

But after thinking all of this, it strikes me that the work done here is
*very* similar to the work done by the SLP vectorizer for loads and stores.
I think there is at least the possibility that this should be done by the
SLP vectorizer, or that some of the logic should be shared. I'd appreciate
Arnold's, Raul's, Nadav's, and Hal's thoughts on this idea.


On Thu, May 1, 2014 at 3:44 PM, Michael Spencer <bigcheesegs at gmail.com>wrote:

> Adding llvm-commits to CC.
>
> http://reviews.llvm.org/D3580
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140501/e34939ea/attachment.html>


More information about the llvm-commits mailing list