[PATCH] Move logic for calculating DBG_VALUE history map into separate file/class.

Eric Christopher echristo at gmail.com
Wed Apr 30 13:59:17 PDT 2014


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1474
@@ +1473,3 @@
+        getDISubprogram(DV.getContext()).describes(MF->getFunction()))
+      LabelsBeforeInsn[History[0]] = FunctionBeginSym;
+
----------------
Alexey Samsonov wrote:
> David Blaikie wrote:
> > I'd probably write History.front() (rather than History[0]), but reasonable people may disagree - just a thought.
> Done.
No objections, not necessarily for it either, but I like to think I'm reasonable and I don't disagree :)

http://reviews.llvm.org/D3573






More information about the llvm-commits mailing list