[llvm] r207627 - [ARM64] Fix stupid copy-pasto in ARM64MCAsmInfo.cpp - aarch64_be -> arm64_be

[James Molloy]

Hi David,

I've added a testcase in r207697. I realised why I coudn't reproduce it -
it only showed up when emitting ELF, not assembly.

Thanks for the prod!

James


On 30 April 2014 19:41, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Apr 30, 2014 at 11:25 AM, James Molloy <James.Molloy at arm.com>
> wrote:
> > Hi David,
> >
> > It looks like it should be trivial to test, however I failed :(
> >
> > This was originally noticed because of a disparity between the layout of
> a constant pool and a MOVK'd immediate.
>
> Sounds like you've got a reproduction, then.
>
> > When writing a testcase (albeit after the fact - should probably have
> done it at the same time) I couldn't get it to trigger.
> >
> > I can try harder to get a testcase tomorrow when I'm not as bleary-eyed
> as I was when I tried before though if you like?
>
> That'd be swell, thanks.
>
> > I definitely agree with you that everything should be tested if
> possible. It's just that stuff in the backend gets difficult to test.
>
> Yeah - there are sometimes good reasons not to commit tests for some
> of this stuff (mostly around the inability to run small pieces of the
> backend in isolation so tests tend to be rather fragile due to other
> optimizations in the backends causing the test to fail or to no longer
> test their intent) - but this particular one seems like a pretty
> significant/important distinction. (which endianness we use... )
>
> >
> > Cheers,
> >
> > James
> >
> >> -----Original Message-----
> >> From: David Blaikie [mailto:dblaikie at gmail.com]
> >> Sent: 30 April 2014 18:55
> >> To: James Molloy
> >> Cc: llvm-commits at cs.uiuc.edu
> >> Subject: Re: [llvm] r207627 - [ARM64] Fix stupid copy-pasto in
> >> ARM64MCAsmInfo.cpp - aarch64_be -> arm64_be
> >>
> >> On Wed, Apr 30, 2014 at 3:15 AM, James Molloy <james.molloy at arm.com>
> >> wrote:
> >> > Author: jamesm
> >> > Date: Wed Apr 30 05:15:46 2014
> >> > New Revision: 207627
> >> >
> >> > URL: http://llvm.org/viewvc/llvm-project?rev=207627&view=rev
> >> > Log:
> >> > [ARM64] Fix stupid copy-pasto in ARM64MCAsmInfo.cpp - aarch64_be ->
> >> arm64_be
> >>
> >> I'm assuming this is testable?
> >>
> >> > Modified:
> >> >     llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCAsmInfo.cpp
> >> >
> >> > Modified:
> >> llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCAsmInfo.cpp
> >> > URL: http://llvm.org/viewvc/llvm-
> >> project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCAsmInfo.cp
> >> p?rev=207627&r1=207626&r2=207627&view=diff
> >> >
> >> ==========================================================
> >> ====================
> >> > --- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCAsmInfo.cpp
> >> (original)
> >> > +++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCAsmInfo.cpp
> >> Wed Apr 30 05:15:46 2014
> >> > @@ -66,7 +66,7 @@ const MCExpr *ARM64MCAsmInfoDarwin::getE
> >> >
> >> >  ARM64MCAsmInfoELF::ARM64MCAsmInfoELF(StringRef TT) {
> >> >    Triple T(TT);
> >> > -  if (T.getArch() == Triple::aarch64_be)
> >> > +  if (T.getArch() == Triple::arm64_be)
> >> >      IsLittleEndian = false;
> >> >
> >> >    // We prefer NEON instructions to be printed in the short form.
> >> >
> >> >
> >> > _______________________________________________
> >> > llvm-commits mailing list
> >> > llvm-commits at cs.uiuc.edu
> >> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
> > -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium.  Thank you.
> >
> > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> Registered in England & Wales, Company No:  2557590
> > ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1
> 9NJ, Registered in England & Wales, Company No:  2548782
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140430/fb4f7c51/attachment.html>