[PATCH] Some code improvements (no functional change)

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Apr 30 11:06:36 PDT 2014


On 2014-Apr-30, at 4:12, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:

> For example, Google C++ Style Guide mandates: "All parameters passed by
> reference must be labeled const. [...] it is a very strong convention in
> Google code that input arguments are values or const references while output
> arguments are pointers." (
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Reference_Arg
> uments )

I haven't seen much of that around here.

> I see that LLVM Coding Standards document doesn't touch this subject at all.
> Should we use this opportunity to add to it that in LLVM, the choice between
> pointer parameters and reference parameters is defined by whether NULL is a
> valid input?

Not sure that's necessary, but feel free to send a proposal to llvmdev.



More information about the llvm-commits mailing list