[PATCH] IR: Conservatively verify inalloca arguments
Reid Kleckner
rnk at google.com
Wed Apr 30 10:24:13 PDT 2014
LGTM
Chandler was pushing to put this in the lint pass, but I don't agree. If he feels strongly, he can argue for it in post-commit review.
================
Comment at: lib/IR/Verifier.cpp:865
@@ -864,2 +864,3 @@
"inalloca isn't on the last parameter!", V);
+ //
}
----------------
stray bit
================
Comment at: lib/IR/Verifier.cpp:1499
@@ +1498,3 @@
+ // Conservatively check the inalloca argument.
+ // We have a bug If we can find that there is an underlying alloca without
+ // inalloca.
----------------
s/If/if/
http://reviews.llvm.org/D3572
More information about the llvm-commits
mailing list