[PATCH] ELFObjectWriter: optimize suffices in strtab

[Rafael Ávila de Espíndola]

I am in favour of moving this to its own file, by why ADT? All the listed potential users would be using lib/Object, so it can stay there, no?

LGTM with the class being somewhere in lib/Object.

================
Comment at: lib/Support/StringTableBuilder.cpp:35
@@ +34,3 @@
+
+  StringTable += '\x00';
+  StringRef Previous;
----------------
Starting the table with a null character makes this ELF specific? That is fine for now, but please comment.

================
Comment at: test/MC/ELF/symref.s:116
@@ -115,3 +115,3 @@
 // CHECK-NEXT:   Symbol {
-// CHECK-NEXT:     Name: global1 (66)
+// CHECK-NEXT:     Name: global1 (65)
 // CHECK-NEXT:     Value: 0x14
----------------
Just remove the number. The printed name is all that the test needs. These are leftover from the old and horrible elf-dump script.

http://reviews.llvm.org/D3533