[PATCH][PM] Add pass run listeners to the pass manager.

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Apr 29 11:44:04 PDT 2014


On 2014-Apr-28, at 16:29, Chandler Carruth <chandlerc at google.com> wrote:

> 
> On Mon, Apr 28, 2014 at 4:17 PM, Reid Kleckner <rnk at google.com> wrote:
> On Mon, Apr 28, 2014 at 4:08 PM, Chandler Carruth <chandlerc at google.com> wrote:
> Second, why are you defining a new callback type? We have std::function now, so I would expect this to be std::function<void(Pass *)>.
> 
> We do? http://llvm.org/docs/CodingStandards.html#supported-c-11-language-and-library-features
> 
> Arrrg. But I hear someone is working on it.
> 
> Another good reason to not bake this stuff into the C API.

I don't think this bakes in the C++-side of the callback type.  Unless
I've misread the patch, we can change the storage to a std::function<>
once we're allowed to use them.

We're never going to have std::function<> on the C side.



More information about the llvm-commits mailing list