[lld] r207495 - [Mips] Re-order include headers.

David Blaikie dblaikie at gmail.com
Tue Apr 29 08:17:45 PDT 2014


On Mon, Apr 28, 2014 at 10:46 PM, Simon Atanasyan <simon at atanasyan.com> wrote:
> Author: atanasyan
> Date: Tue Apr 29 00:46:02 2014
> New Revision: 207495
>
> URL: http://llvm.org/viewvc/llvm-project?rev=207495&view=rev
> Log:
> [Mips] Re-order include headers.

Any particular reason?

(side note: usually it's a good habit to include the *.cpp's *.h file
first - this helps check that the header file includes everything
necessary to compile (since it comes first it can't depend on anything
else - though I don't believe this is a consistent policy in LLVM)

>
> Modified:
>     lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
>
> Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp?rev=207495&r1=207494&r2=207495&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp Tue Apr 29 00:46:02 2014
> @@ -7,13 +7,11 @@
>  //
>  //===----------------------------------------------------------------------===//
>
> +#include "MipsELFFile.h"
>  #include "MipsLinkingContext.h"
>  #include "MipsRelocationPass.h"
>  #include "MipsTargetHandler.h"
>
> -#include "Atoms.h"
> -#include "MipsELFFile.h"
> -
>  #include "llvm/ADT/DenseSet.h"
>
>  using namespace lld;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list