[PATCH][LoopStrengthReduce] Don't trim a formula that uses a subset of required registers

Chandler Carruth chandlerc at google.com
Mon Apr 28 17:05:56 PDT 2014


I don't object to having the fix checked in but:

On Mon, Apr 28, 2014 at 4:51 PM, Andrew Trick <atrick at apple.com> wrote:

> one of the major difficulties in getting it fixed was we just have
> absolutely no way to force it in llc


This is *exactly* why we should absolutely spend time isolating what it is
about this test case that doesn't reproduce with llc. This is *critical* to
the LLVM test infrastructure and project. It's not something we can or
should paper over, for exactly the reason you described: it makes finding
these bugs nearly impossible.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140428/dff00483/attachment.html>


More information about the llvm-commits mailing list