[PATCH] Fix assertion with a trunc store to an i1 vector.

Nadav Rotem nrotem at apple.com
Mon Apr 28 16:59:03 PDT 2014


The change to LegalizeDAG.cpp looks incorrect. If vXi1 is not a legal type then we need to bit pack it. Your code zero-extends it, which is the wrong representation. 

On Apr 28, 2014, at 4:24 PM, Quentin Colombet <qcolombet at apple.com> wrote:

> + Nadav and Hal.
> 
> -Quentin
> 
> On Apr 28, 2014, at 4:22 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> 
>> IIRC the semantic of Y x i1 is a packed vector of bool. I.e., you just need Y bits to hold the whole vector. This matches the AVX-512 vector mask.
>> That said, I do not find the thread discussing that and may be wrong.
>> 
>> Adding Nadav and Hal may be a good idea.
>> 
>> -Quentin
>> 
>> http://reviews.llvm.org/D3163
>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140428/f22c1b48/attachment.html>


More information about the llvm-commits mailing list