[PATCH] [OPENMP][LV] Respect Hints.Force meta-data for loops in LoopVectorizer
Tyler Nowicki
tnowicki at apple.com
Mon Apr 28 11:54:59 PDT 2014
Hi Zinovy,
Sorry for the delay.
LGTM. Just a few small things.
+ // Check the loop for a trip count threshold:
+ // do not vectorize loops with a tiny trip count.
+ {
+ BasicBlock *Latch = L->getLoopLatch();
Could you remove the extra braces?
+ if (ForceVectorization && VF > 1) {
+ Width = 2;
+ Cost = expectedCost(Width) / (float)Width;
+ }
Could you add a comment to explain that scalar width is not considered because the user wants vectorization.
Thanks for working on this,
Tyler
On Apr 28, 2014, at 2:00 AM, Zinovy Nis <zinovy.nis at gmail.com> wrote:
> One more ping.
>
> http://reviews.llvm.org/D3423
>
>
More information about the llvm-commits
mailing list