[llvm] r207301 - [X86] Implement TargetLowering::getScalingFactorCost hook.

Quentin Colombet qcolombet at apple.com
Mon Apr 28 10:11:48 PDT 2014


+Dan
On Apr 28, 2014, at 10:01 AM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote:

> On 4/28/2014 11:45 AM, Quentin Colombet wrote:
>> For the record, we’ve already proposed a target-specific DAG combine to
>> be run before any target independent DAG combine.
>> This was rejected at the time:
>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130128/163692.html
> 
> There is a claim there that "this is counter to the design of the DAG combiner", and that the design was modeled after instr-combiner, but there was no word about why this was made into a design principle.  What was the reason behind this attempt at canonicalization?  Does anyone remember?
Maybe Dan?

-Quentin
> 
> -Krzysztof
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation





More information about the llvm-commits mailing list