[PATCH] Fix typo in MCObjectDisassembler::getBBAt()

Duncan P. N. Exon Smith dexonsmith at apple.com
Sun Apr 27 18:19:59 PDT 2014


Hi Maks,

This change is obviously correct, but it should still be possible
to create a failing testcase:  it looks to me like no basic blocks
will have successor/predecessor edges without your fix.

(I.e., please write a testcase!)

> maksqwe added you to the CC list for the revision "Fix typo in MCObjectDisassembler::getBBAt()".
> 
> Hi dblaikie,
> 
> http://reviews.llvm.org/D3436
> 
> Files:
>  lib/MC/MCObjectDisassembler.cpp
> 
> Index: lib/MC/MCObjectDisassembler.cpp
> ===================================================================
> --- lib/MC/MCObjectDisassembler.cpp
> +++ lib/MC/MCObjectDisassembler.cpp
> @@ -448,7 +448,7 @@
>     RemoveDupsFromAddressVector(BBI->SuccAddrs);
>     for (AddressSetTy::const_iterator SI = BBI->SuccAddrs.begin(),
>          SE = BBI->SuccAddrs.end();
> -         SE != SE; ++SI) {
> +         SI != SE; ++SI) {
>       MCBasicBlock *Succ = BBInfos[*SI].BB;
>       BB->addSuccessor(Succ);
>       Succ->addPredecessor(BB);
> <D3436.1.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

http://reviews.llvm.org/D3436






More information about the llvm-commits mailing list