[PATCH][PM] Add pass run listeners to the pass manager.

Juergen Ributzka juergen at apple.com
Sun Apr 27 12:49:13 PDT 2014

On Apr 26, 2014, at 11:33 PM, Andrew Trick <atrick at apple.com> wrote:

> I like this feature, and your implementation seems quite thorough. The only thing I don’t understand is why passRun() needs to take an LLVMContext when the PassRunListener is already holding a pointer to one.

Go catch. I forgot to remove the LLVMContext from the PassRunListener.

> We should probably have a basic unit test case. Maybe in the MCJIT C API tests?

Yup, I added a test to the file.

> Thanks!
> -Andy

I updated the patch and I also modified the runPass callback interface. Now it also provides information about the module, function, and basic block the pass ran on. This interface could be used for example to easily implement a PrintAfterAll pass listener.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140427/ef6454d5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PM-Add-pass-run-listeners-to-the-pass-manager-v3.patch
Type: application/octet-stream
Size: 17798 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140427/ef6454d5/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140427/ef6454d5/attachment-0001.html>

More information about the llvm-commits mailing list