[PATCH] ARM: provide a generic hint intrinsic

[Tim Northover]

Hi Saleem,

It mostly looks straightforward, but I'd make the patterns more generic: hints 0-5 already have defined meanings, but the whole point of the instruction is that it's more generic than that. There's no particular reason to exclude any number in the space.

Cheers.

Tim.

================
Comment at: lib/Target/ARM/ARMInstrInfo.td:1845-1850
@@ -1844,1 +1844,8 @@
 
+def : Pat<(int_arm_hint 0), (HINT 0)>;
+def : Pat<(int_arm_hint 1), (HINT 1)>;
+def : Pat<(int_arm_hint 2), (HINT 2)>;
+def : Pat<(int_arm_hint 3), (HINT 3)>;
+def : Pat<(int_arm_hint 4), (HINT 4)>;
+def : Pat<(int_arm_hint 5), (HINT 5)>;
+
----------------
I'd put the pattern into the generic HINT instruction: hints 0-5 have fairly tied down meanings, but the whole point of the mechanism is that it's more generic than that.

http://reviews.llvm.org/D3492