[PATCH] Add an -mattr option to the gold plugin to support subtarget features in LTO

Tom Roeder tmroeder at google.com
Thu Apr 24 17:20:57 PDT 2014


On Thu, Apr 24, 2014 at 2:49 PM, Dan Gohman <dan433584 at gmail.com> wrote:
> On Thu, Apr 24, 2014 at 12:18 PM, Tom Roeder <tmroeder at google.com> wrote:
>>
>> On Tue, Apr 22, 2014 at 4:37 PM, Nick Kledzik <kledzik at apple.com> wrote:
>> > Tom,
>> >
>> > Your patch is fine with me.  It is a reasonable work around until we
>> > start encoding all those attributes in bitcode.
>> >
>> > -Nick K.
>> >
>>
>> Great!
>>
>> Dan: I think Rafael wanted your opinion on this, too, given your work
>> on a longer-term solution for this problem. Is this OK with you?
>
>
> I have no objection to this as a short-term measure either.
>
> Dan
>

Rafael, can I take your original email as LGTM then on the patch?

Tom



More information about the llvm-commits mailing list