[PATCH] Remove AssemblyAnnotationWriter from NamedMDNode::print

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Apr 23 05:03:23 PDT 2014


LGTM. Do you have commit access?

On 15 April 2014 13:57, Robert Matusewicz <matekm at gmail.com> wrote:
> Hi #llvm,
>
> No functionality change, this parameter was always set to nullptr.
>
> http://reviews.llvm.org/D3382
>
> Files:
>   include/llvm/IR/Metadata.h
>   lib/IR/AsmWriter.cpp
>
> Index: include/llvm/IR/Metadata.h
> ===================================================================
> --- include/llvm/IR/Metadata.h
> +++ include/llvm/IR/Metadata.h
> @@ -272,7 +272,7 @@
>    StringRef getName() const;
>
>    /// print - Implement operator<< on NamedMDNode.
> -  void print(raw_ostream &ROS, AssemblyAnnotationWriter *AAW = nullptr) const;
> +  void print(raw_ostream &ROS) const;
>
>    /// dump() - Allow printing of NamedMDNodes from the debugger.
>    void dump() const;
> Index: lib/IR/AsmWriter.cpp
> ===================================================================
> --- lib/IR/AsmWriter.cpp
> +++ lib/IR/AsmWriter.cpp
> @@ -2141,10 +2141,10 @@
>    W.printModule(this);
>  }
>
> -void NamedMDNode::print(raw_ostream &ROS, AssemblyAnnotationWriter *AAW) const {
> +void NamedMDNode::print(raw_ostream &ROS) const {
>    SlotTracker SlotTable(getParent());
>    formatted_raw_ostream OS(ROS);
> -  AssemblyWriter W(OS, SlotTable, getParent(), AAW);
> +  AssemblyWriter W(OS, SlotTable, getParent(), nullptr);
>    W.printNamedMDNode(this);
>  }
>
> @@ -2247,4 +2247,4 @@
>  void Module::dump() const { print(dbgs(), nullptr); }
>
>  // NamedMDNode::dump() - Allow printing of NamedMDNodes from the debugger.
> -void NamedMDNode::dump() const { print(dbgs(), nullptr); }
> +void NamedMDNode::dump() const { print(dbgs()); }
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list